Fix testPurgeCacheEntriesForDatabase on Windows
#129648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our hypothesis is that the path is not round-tripping on Windows. This fixes the test by always using the canonical string for the path, when inserting and when purging. Closes elastic#129635
PeteGillinElastic
added
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
prdoyle
approved these changes
Jun 18, 2025
Contributor
prdoyle
left a comment
prdoyle
left a comment
There was a problem hiding this comment.
The test seems reasonable, and looks like what we do elsewhere to accommodate Windows. If it passes test-windows then I think we're good to go.
modules/ingest-geoip/src/test/java/org/elasticsearch/ingest/geoip/GeoIpCacheTests.java
Outdated
Show resolved
Hide resolved
nielsbauman
approved these changes
Jun 18, 2025
Member
Author
|
Okay, I have made three attempts to get CI to pass, and I think it's failed three different times (at least two different times). The most recent one is in |
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
Our hypothesis is that the path is not round-tripping on Windows. This fixes the test by always using the canonical string for the path, when inserting and when purging. Fixes elastic#129635
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
Our hypothesis is that the path is not round-tripping on Windows. This fixes the test by always using the canonical string for the path, when inserting and when purging. Fixes elastic#129635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our hypothesis is that the path is not round-tripping on Windows. This fixes the test by always using the canonical string for the path, when inserting and when purging.
Closes #129635